Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Use Proxy from common #2377

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexeykazakov
Copy link
Contributor

@alexeykazakov alexeykazakov commented Dec 11, 2018

Address issue in our proxy which we found after upgrading go to 1.11. See fabric8-services/fabric8-auth#734

@alien-ike
Copy link

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6c2caea). Click here to learn what that means.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2377   +/-   ##
=========================================
  Coverage          ?   69.89%           
=========================================
  Files             ?      170           
  Lines             ?    16961           
  Branches          ?        0           
=========================================
  Hits              ?    11855           
  Misses            ?     3948           
  Partials          ?     1158
Impacted Files Coverage Δ
controller/collaborators.go 0% <0%> (ø)
controller/users.go 73.98% <0%> (ø)
controller/search.go 70.24% <0%> (ø)
controller/login.go 41.66% <0%> (ø)
controller/features.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2caea...a0e0635. Read the comment docs.

@alexeykazakov
Copy link
Contributor Author

This PR is ready for review. It's WIP until we finish additional testing to make sure the issue is fixed by this PR.

@alexeykazakov alexeykazakov changed the title WIP: Use Proxy from common Use Proxy from common Dec 12, 2018
@sbose78
Copy link
Member

sbose78 commented Dec 18, 2018

To be merged after upgrading to go1.11 #2378

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants