fix(datatable): move datatable-config from component to ngrx (#2614)

* fix(datatable): move datatable-config from component to ngrx, increase width of type column * fix(datatable): update the version of column cookie
fabric8-ui · May 21, 2018 · cf9f768 · cf9f768
1 parent 9184140
commit cf9f768
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 16 deletions.
diff --git a/src/app/components/planner-list/planner-list.component.ts b/src/app/components/planner-list/planner-list.component.ts
@@ -47,9 +47,6 @@ import { Space, Spaces } from 'ngx-fabric8-wit';
 
 import { EmptyStateConfig } from 'patternfly-ng/empty-state';
 
-// import for column
-import { datatableColumn } from './datatable-config';
-
 import { WorkItemCellComponent } from '../work-item-cell/work-item-cell.component'
 import { WorkItem } from '../../models/work-item';
 import { WorkItemDetailComponent } from './../work-item-detail/work-item-detail.component';
@@ -195,15 +192,6 @@ export class PlannerListComponent implements OnInit, AfterViewChecked, OnDestroy
     this.listenToEvents();
     this.loggedIn = this.auth.isLoggedIn();
 
-    // Cookie for datatableColumn config
-    if(!this.cookieService.getCookie(datatableColumn.length).status) {
-      this.cookieService.setCookie('datatableColumn', datatableColumn);
-      this.columns = datatableColumn;
-    } else {
-      let temp = this.cookieService.getCookie(datatableColumn.length)
-      this.columns = temp.array;
-    }
-
     this.emptyStateConfig = {
       info: 'There are no Work Items for your selected criteria',
       title: 'No Work Items Available'

diff --git a/...mponents/planner-list/datatable-config.ts → ...nts_ngrx/planner-list/datatable-config.ts b/...mponents/planner-list/datatable-config.ts → ...nts_ngrx/planner-list/datatable-config.ts
@@ -18,7 +18,7 @@ export const datatableColumn = [{
   showInDiplay: false,
   maxWidth: undefined,
   minWidth: undefined,
-  width: 160,
+  width: 180,
 }, {
   name: 'Title',
   prop: 'title',

diff --git a/src/app/components_ngrx/planner-list/planner-list.component.ts b/src/app/components_ngrx/planner-list/planner-list.component.ts
@@ -27,7 +27,7 @@ import { cloneDeep, sortBy, isEqual } from 'lodash';
 import { EmptyStateConfig } from 'patternfly-ng/empty-state';
 
 // import for column
-import { datatableColumn } from './../../components/planner-list/datatable-config';
+import { datatableColumn } from './datatable-config';
 
 // ngrx stuff
 import { Store } from '@ngrx/store';

diff --git a/src/app/services/cookie.service.ts b/src/app/services/cookie.service.ts
@@ -3,8 +3,8 @@ import { Injectable } from '@angular/core';
 @Injectable()
 export class CookieService {
   // Increase this by one everytime
-  // a change id made in the table columns
-  datatableColumnVersion = 1;
+  // a change is made in the table columns
+  datatableColumnVersion = 2;
 
   constructor() { }