-
Notifications
You must be signed in to change notification settings - Fork 62
feat(Makefile): use Makefile for running tasks, retiring gulp #2651
Conversation
@debloper Your image is available in the registry. Run |
Can you write a readme for this? How do we build the planner with this setup? |
@sanbornsen don't you worry sire, coming right up. 🤓 I want to keep the Makefile side-by-side with Gulp for a few weeks though (for everyone to catch up in their free time, and not end up being forced to learn new thing when they would rather work on something else). Both will generate same results, and not be blocking each other - so, during this transition phase, you're free to use either/both. During this phase, I'll follow up another patch that replaces Gulp in the CI/CD and also incorporates all the ad-hoc scripts we have lying around in the repo as Makefile targets which are too complicated for a gulp-task (e.g. |
@debloper Your image is available in the registry. Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention the experience or scenario that this PR addresses.
5ee600b
to
8c37bee
Compare
@debloper Your image is available in the registry. Run |
@debloper Your image is available in the registry. Run |
1 similar comment
@debloper Your image is available in the registry. Run |
Took @jarifibrahim through the code and implementation, along with comparing it against the Gulpfile. |
Since we are moving to a monorepo and this is really out of date, I'm closing it. |
What does this PR do?
This sets up the base to replace Gulp as a task runner, with Make. For the moment, both will work so that developers can get accustomed with the new set of commands. Once the transition phase is over, Gulp can be safely removed from repo and Make can take its place as user-run commands as well as in CI/CD routines.
What issue/task does this PR references?
#2506 & https://openshift.io/openshiftio/openshiftio/plan/detail/2419
Are the tests Included?
Not Applicable