minerva-ag: Fix unexpected sleep at init #2146
Conversation
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Victor-Jhong
force-pushed
the
minerva-ag/fix_unexpected_sleep_at_init
branch
from
4fafa78 to
0c51c4b
Compare
|
@Victor-Jhong has updated the pull request. You must reimport the pull request before landing. |
| @@ -184,6 +184,6 @@ void init_cpld_polling(void) | |||
| cpld_polling_tid = k_thread_create( | |||
| &cpld_polling_thread, cpld_polling_stack, K_THREAD_STACK_SIZEOF(cpld_polling_stack), | |||
| poll_cpld_registers, NULL, NULL, NULL, CONFIG_MAIN_THREAD_PRIORITY, 0, | |||
| K_MSEC(3000)); //sleep for 3 seconds to prevent dc status changing when reboot BIC | |||
| K_MSEC(2000)); //sleep for 3 seconds to prevent dc status changing when reboot BIC | |||
There was a problem hiding this comment.
Can you please change the comment as well to reflect 2 instead of 3?
There was a problem hiding this comment.
Thank you for the feedback. I have updated the comment to clarify the behavior. The total delay before accessing CPLD is 3 seconds, not 2. Here's the breakdown:
- 2-second delay comes from K_MSEC(2000) in k_thread_create.
- 1-second delay comes from CPLD_POLLING_INTERVAL_MS at the start of the thread handler loop.
|
@Victor-Jhong has updated the pull request. You must reimport the pull request before landing. |
|
This pull request has been merged in abfb5ed. |
Summary:
Test Plan: