Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-tx] Fix Type Errors #1602

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[py-tx] Fix Type Errors #1602

merged 2 commits into from
Jul 10, 2024

Conversation

aryzle
Copy link
Collaborator

@aryzle aryzle commented Jul 10, 2024

Summary

fixes #1568

  • python -m mypy threatexchange was failing before, fixed type errors

Also fixed python-threatexchange devcontainer build problems

  • couldn't build vpdq before, needed to install cmake and required packages found here

Test Plan

tested in devcontainer inside python-threatexchange dir

@aryzle aryzle requested a review from Dcallies as a code owner July 10, 2024 01:31
Dcallies
Dcallies approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@Dcallies Dcallies merged commit ee9b1b5 into facebook:main Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dcallies Dcallies Dcallies approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hma][py-tx] Unclean CI status for HMA and pytx
3 participants
@aryzle @Dcallies @facebook-github-bot