Fix fb_systemd on hosts without networkd #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: If you don't use networkd (and `fb_networkd`), then this code in `fb_system::networkd` Test Plan: @anitazha did some testing of this internal to Meta already, plus I've rolled this out to the SCALE infra
|
@joshuamiller01 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dafyddcrosby
approved these changes
Mar 20, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Test Plan: Tested that this didn't result in a networkd config change on CentOS9, and that it stops managing the networkd config on CentOS8, which is fine since we aren't using networkd on CentOS8 at least internally. anitazha did some testing of this internal to Meta already, plus I've rolled this out to the SCALE infra Differential Revision: D55154300 fbshipit-source-id: db4822e2df0ab65258a204c881afd042898cd0a5
|
Looks like this didn't get auto-closed, thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fb_systemd on hosts without networkd
Summary:
If you don't use networkd (and
fb_networkd), then this code infb_system::networkdTest Plan:
@anitazha did some testing of this internal to Meta already, plus
I've rolled this out to the SCALE infra