fb_apache: Add 'manage_service' configurable #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is sometimes desired to have apache configured but not running. Allow the user to manage the service themselves, just like we do with packages. Of course, the default remains that Chef manages the service. I added a few nicities here: * For those who were using `manage_packages=false`, you can now easily get the list of packages cleanly * You also easily get the right service name Signed-off-by: Phil Dibowitz <[email protected]>
|
@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 0ff8688. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes desired to have apache configured but not running.
Allow the user to manage the service themselves, just like we do
with packages. Of course, the default remains that Chef manages
the service.
I added a few nicities here:
manage_packages=false, you can now easilyget the list of packages cleanly
Signed-off-by: Phil Dibowitz [email protected]