fix(theme-classic): Debounce during onRouteUpdate in classic theme #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using window.setTimeout may cause the bar to remain in StrictMode (in my testing). Signed-off-by: seyoon20087 <[email protected]>
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Forgot to run prettier before pushing Signed-off-by: seyoon20087 <[email protected]>
|
Thanks for your proposal, but Docusaurus does not support strict mode yet, and we don't want to introduce lodash in the client-side bundle I'll figure this out when we add strict mode support, but for now it is not useful to fix a bug that we don't have in the first place. We'll fix problems once we support strict mode, as part of the PR that brings support for it. |
slorber
added
the
closed: wontfix
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10036.
Pre-flight checklist
Motivation
Debouncing instead of using
window.setTimeout()fixes this issue.Test Plan
See PoC (the loading bar does not appear in development anymore):
Screen.Recording.2024-04-10.at.8.55.14.PM.mov
Test links
Deploy preview: https://deploy-preview-10037--docusaurus-2.netlify.app/
Related issues/PRs
#10036