Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore more playwright console errors #10117

Merged
merged 1 commit into from
May 9, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 9, 2024

Motivation

Argos/Playwrite CI is stuck on main due to some hydration errors that remain to be fixed

For now I ignore the errors that already existed before, but we'll have to fix those at some point

Test Plan

CI

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 9, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 9, 2024 11:27
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 9, 2024
@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label May 9, 2024
Copy link

netlify bot commented May 9, 2024

[V2]

Name Link
🔨 Latest commit a84de98
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/663cb3322a8ead0008838cee
😎 Deploy Preview https://deploy-preview-10117--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 9, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 37 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 52 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

argos-ci bot commented May 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 3 added May 9, 2024, 11:35 AM

@slorber slorber merged commit 02f5d70 into main May 9, 2024
11 of 12 checks passed
@slorber slorber deleted the slorber/fix-argos-screenshots branch May 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants