fix(theme-common): code block magic comments should support SQL block comments #10782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add jsBlock comment style to sql code block.
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
reviewed
Dec 20, 2024
There was a problem hiding this comment.
That looks fine but I have no easy way to review
Can you add a dogfood test in docusaurus/website/_dogfooding/_pages tests/code-block-tests.mdx ?
https://docusaurus.io/tests/pages/code-block-tests#magic-comments-tests
|
Thanks for the input, I will update tests. |
Added test in https://docusaurus.io/tests/pages/code-block-tests#magic-comments-tests Using block comment style.
slorber
approved these changes
Dec 20, 2024
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Code block magic comments should support SQL block comments
/* comment */Test Plan
Dogfood / preview
Test links
https://deploy-preview-10782--docusaurus-2.netlify.app/tests/pages/code-block-tests#magic-comments-tests
Related issues/PRs
Fix #10748