Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): Footer Column/Link should merge provided className #10796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 24, 2024

Motivation

We should be able to assign className to footer columns/items

The className should be merged to the default class instead of overriding it, for consistency with the behavior of navbar items, as suggested here: #10785 (comment)

{
      footer: {
        style: 'dark',
        links: [
          {
            title: 'Legal',
            className: 'footer-column-legal',
            items: [
              {
                label: 'Privacy',
                className: 'footer-item-privacy',
                href: 'https://opensource.facebook.com/legal/privacy/',
              },
            ],
          },
        ],
      },
}

Test Plan

CI + dogfood on preview site footer

Test links

https://deploy-preview-10796--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 24, 2024
@slorber slorber requested a review from Josh-Cena as a code owner December 24, 2024 16:24
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 24, 2024
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 35 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 50 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 65 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants