refactor(core): Use Intl native API to get locale direction, remove rtl-detect depend… #10798
+11
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +335 B (0%) Total Size: 11.5 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +325 B (0%) Total Size: 11.9 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Node 18.0+ implements a standard Intl method to retrieve the text direction of a given locale. This enables us to remove an unnecessary npm dependency.
Note: the proposal recently progressed to stage 3 so it is unlikely to disappear.
However, v8/node currently implements an older version of the proposal (using
.textInfoinstead of.getTextInfo()so I'm using this API defensively to support all node versions >= 18See also:
Test Plan
CI, unit tests keep passing