-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin Rackmon ORV3 support #288
Open
geoffhanson
wants to merge
1
commit into
facebook:main
Choose a base branch
from
geoffhanson:upstream_darwin_rackmon_orv3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Darwin Rackmon ORV3 support #288
geoffhanson
wants to merge
1
commit into
facebook:main
from
geoffhanson:upstream_darwin_rackmon_orv3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide additional config and enhancements to Rackmon logic to support ORV3 for Darwin. Darwin is the only platform so far to support Rackmon from FBOSS. Motivation: Support ORV3 with Darwin. Test Plan: On a Darwin system connected to PSUs and BBUs, used the thriftctl utility to verify rackmon was monitoring the devices: [root@rkdo301 ~]# thriftctl listPorts 5909: neteng.fboss.ctrl.FbossCtrl 5910: neteng.fboss.qsfp.QsfpService 5931: neteng.fboss.hw_ctrl.FbossHwCtrl 5932: neteng.fboss.hw_ctrl.FbossHwCtrl 5970: neteng.fboss.platform.sensor_service.SensorServiceThrift 5972: fan_service.FanService 5973: rackmonsvc.rackmonsvc.RackmonCtrl [root@rkdo301 ~]# thriftctl listMethods -p 5973 Found 10 available methods under port:5973 controlRackmond getMonitorData getMonitorDataEx getPowerLossSiren listModbusDevices presetMultipleRegisters readFileRecord readHoldingRegisters reload writeSingleRegister [root@rkdo301 ~]# thriftctl request listModbusDevices -p 5973 [ModbusDeviceInfo( devAddress=64, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=65, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=66, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=67, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=68, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=69, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=96, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=97, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=98, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=99, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=100, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=101, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=3), ModbusDeviceInfo( devAddress=200, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=201, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=202, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=203, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=204, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=205, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=232, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=233, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=234, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=235, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=236, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1), ModbusDeviceInfo( devAddress=237, mode=0, baudrate=19200, timeouts=0, crcErrors=0, miscErrors=0, deviceType=1)] [root@rkdo301 ~]# thriftctl request getMonitorData -p 5973 > /tmp/monitordata.txt
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@geoffhanson are you able to run the rackmon HW tests that are part of OSS? I see some of them are failing on-diff internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide additional config and enhancements to Rackmon logic to support ORV3 for Darwin. Darwin is the only platform so far to support Rackmon from FBOSS.
Test Plan:
On a Darwin system connected to PSUs and BBUs, used the thriftctl utility to verify rackmon was monitoring the devices:
Monitored data is attached to this PR.
rackmondata.txt