Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type-definition] Proper overload for assert.fail #7915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AVykhrystyuk
Copy link
Contributor

Currently I get the following error when I have assert.fail with one argument:

Cannot call assert.fail because function [1] requires another argument.
     src/index.spec.js
       35│         assert.fail('message');

     /private/tmp/flow/flowlib_2209bba7/node.js
 [1] 2443│     fail(actual: any, expected: any, message: string, operator: string): void,

Fixes #6799

Redo the work being merged in https://github.com/facebook/flow/pull/7482/files

Related docs:
Single argument method overload - https://nodejs.org/docs/latest-v10.x/api/assert.html#assert_assert_fail_message

Deprecated method - https://nodejs.org/docs/latest-v10.x/api/assert.html#assert_assert_fail_actual_expected_message_operator_stackstartfn

@goodmind
Copy link
Contributor

Related #7660

@goodmind goodmind added the Library definitions Issues or pull requests about core library definitions label Jul 10, 2019
@goodmind goodmind added the node label Jul 16, 2019
@AVykhrystyuk
Copy link
Contributor Author

also related #7248

@goodmind goodmind added the Stalled Issues and PRs that are stalled. label Jul 27, 2019
@farzonl
Copy link
Contributor

farzonl commented Sep 24, 2019

whats the hold up on this change?

@goodmind
Copy link
Contributor

There's two conflicting PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions node Stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in flow/flow_lib/node.js is missing assert.fail([message])
4 participants