fix: fmt workaround for pkg-config generation #2293
Conversation
|
Hi @aminya! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
aminya
force-pushed
the
fmt-workaround
branch
from
75f0b98
to
c025886
Compare
|
CLA signed @facebook-github-bot |
aminya
force-pushed
the
fmt-workaround
branch
from
c025886
to
3228d59
Compare
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Workaround for facebook/folly#2250. Ideally, the code should support the generator expression, but this workaround fixes the problem for fmt. Also, see fmtlib/fmt#4159 and microsoft/vcpkg#40944 X-link: facebook/folly#2293 Reviewed By: Gownta Differential Revision: D62785183 Pulled By: Orvid fbshipit-source-id: d45768f12d28f53122fdedfc396f1d27c7259d19
Workaround for #2250.
Ideally, the code should support the generator expression, but this workaround fixes the problem for fmt.
Also, see fmtlib/fmt#4159 and microsoft/vcpkg#40944