-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-list] Bug Fix: Prevent error when calling formatList when selection is at root #6994
Open
amanharwara
wants to merge
4
commits into
facebook:main
Choose a base branch
from
standardnotes:replace-on-root-nodes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6393d7a
[lexical-list] Bug Fix: Prevent error when calling formatList when se…
amanharwara 4c7e080
Use rootOrShadowRoot guard, remove recursion and add test
amanharwara df8a227
Merge branch 'main' into replace-on-root-nodes
amanharwara ce1a159
fix import
amanharwara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
72 changes: 72 additions & 0 deletions
72
packages/lexical-list/src/__tests__/unit/formatList.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
import { | ||
$createTableCellNode, | ||
$createTableNode, | ||
$createTableRowNode, | ||
TableCellNode, | ||
TableNode, | ||
TableRowNode, | ||
} from '@lexical/table'; | ||
import {$getRoot} from 'lexical'; | ||
import {initializeUnitTest} from 'lexical/src/__tests__/utils'; | ||
|
||
import {insertList} from '../../formatList'; | ||
import {$isListNode} from '../../LexicalListNode'; | ||
|
||
describe('insertList', () => { | ||
initializeUnitTest((testEnv) => { | ||
test('inserting with empty root selection', async () => { | ||
const {editor} = testEnv; | ||
|
||
await editor.update(() => { | ||
$getRoot().select(); | ||
}); | ||
|
||
insertList(editor, 'number'); | ||
|
||
editor.read(() => { | ||
const root = $getRoot(); | ||
|
||
expect(root.getChildrenSize()).toBe(1); | ||
|
||
const firstChild = root.getFirstChildOrThrow(); | ||
|
||
expect($isListNode(firstChild)).toBe(true); | ||
}); | ||
}); | ||
|
||
test('inserting with empty shadow root selection', async () => { | ||
const {editor} = testEnv; | ||
|
||
await editor.update(() => { | ||
const table = $createTableNode(); | ||
const row = $createTableRowNode(); | ||
const cell = $createTableCellNode(); | ||
$getRoot().append(table.append(row.append(cell))); | ||
cell.select(); | ||
}); | ||
|
||
insertList(editor, 'number'); | ||
|
||
editor.read(() => { | ||
const cell = $getRoot() | ||
.getFirstChildOrThrow<TableNode>() | ||
.getFirstChildOrThrow<TableRowNode>() | ||
.getFirstChildOrThrow<TableCellNode>(); | ||
|
||
expect(cell.getChildrenSize()).toBe(1); | ||
|
||
const firstChild = cell.getFirstChildOrThrow(); | ||
|
||
expect($isListNode(firstChild)).toBe(true); | ||
}); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem strange that we're not also changing
anchorNode
andanchorNodeParent
here, but maybe$isSelectingEmptyListItem
is always false if this is the case? If that's so, I think it would make more sense to change that to be anelse if
to make it clear that these conditions are mutually exclusive.