[WIP] Create a more user-friendly Dockerfile for images. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
erikwebb
reviewed
Feb 22, 2019
mcrouter/scripts/docker/container/ubuntu-packaged/usr/local/bin/entrypoint.sh
Outdated
Show resolved
Hide resolved
erikwebb
reviewed
Feb 22, 2019
erikwebb
reviewed
Feb 22, 2019
mcrouter/scripts/docker/container/ubuntu-packaged/usr/local/bin/entrypoint.sh
Outdated
Show resolved
Hide resolved
emalloy
force-pushed
the
em/fix_docker_and_make_slim
branch
from
c26d551
to
335ed14
Compare
emailbob
reviewed
Feb 23, 2019
mcrouter/scripts/docker/container/ubuntu-packaged/usr/local/bin/entrypoint.sh
Outdated
Show resolved
Hide resolved
emailbob
reviewed
Feb 23, 2019
mcrouter/scripts/docker/container/ubuntu-packaged/usr/local/bin/entrypoint.sh
Outdated
Show resolved
Hide resolved
emailbob
reviewed
Feb 23, 2019
mcrouter/scripts/docker/container/ubuntu-packaged/usr/local/bin/entrypoint.sh
Outdated
Show resolved
Hide resolved
emailbob
reviewed
Feb 23, 2019
mcrouter/scripts/docker/container/ubuntu-packaged/usr/local/bin/entrypoint.sh
Outdated
Show resolved
Hide resolved
emalloy
force-pushed
the
em/fix_docker_and_make_slim
branch
from
b4be50a
to
4cdee3b
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
emalloy
force-pushed
the
em/fix_docker_and_make_slim
branch
from
4cdee3b
to
ef33012
Compare
…t one written to /etc/mcrouter/mcrouter.json simplify entrypoint. bundle the default mcrouter.json with the Docker image, and now allow to point at an alternative location for the mcrouter json config file
explicitly list and COPY files into the docker image fs
emalloy
force-pushed
the
em/fix_docker_and_make_slim
branch
from
ef33012
to
8152ee7
Compare
arzzen
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] do not merge and more to follow.