Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying the persisting of server setup #344

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

kevinlewi
Copy link
Contributor

Addresses #343

Comment on lines +229 to +230
/// instance of [ServerSetup]. Instead, use [ServerSetup::serialize] and
/// [ServerSetup::deserialize] for this purpose.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// instance of [ServerSetup]. Instead, use [ServerSetup::serialize] and
/// [ServerSetup::deserialize] for this purpose.
/// instance of [`ServerSetup`]. Instead, use [`ServerSetup::serialize`] and
/// [`ServerSetup::deserialize`] for this purpose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styling for the rest of the documentation is not using backticks for the structs / functions at the moment, but I'll try changing this style for the entire file to see how it looks and will address these changes in its own PR.

@kevinlewi kevinlewi marked this pull request as ready for review October 5, 2023 03:52
@kevinlewi kevinlewi merged commit ead80ad into facebook:main Oct 5, 2023
57 checks passed
@daxpedda daxpedda mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants