-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test P-521 #349
Test P-521 #349
Conversation
CI fails because of RustCrypto/elliptic-curves#965, which we are going to wait for anyway. |
518cfe3
to
77970d7
Compare
This is ready to merge now. |
It seems like the maintenance for full_test.rs is getting more and more cumbersome now... any thoughts for how we can make this simpler? And maybe for now, can you also add (in a comment above each new set of constants in full_test.rs) instructions for the cargo command to re-generate those constants? |
Last two commits should address both concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, this is really awesome -- thank you for that refactor! Looks good to me
This adds testing of P-521 through the
p521
crate.Still requires:
FieldElement
conversions can panic RustCrypto/elliptic-curves#965See #290 for a previously similar addition.
See facebook/voprf#127 for the same PR in
voprf
, which isn't required to merge this.