Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: align to draft 16, update dependencies #365

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

cyyynthia
Copy link
Contributor

This PR updates the implementation to (actually) match the draft 16 of the protocol. Most notable (and breaking) change is the change of the context string to OPAQUEv1-. Terminology around aPAKE has been updated to match the changes done in the draft as well (from asymmetric to augmented).

I've also tweaked the cargo deny config to get it working on newer versions (as well as bumping the action to v2), and ditched unmaintained json dependency in favor of serde_json.

Side note, that is probably more of a protocol-level nit than something to do with the lib: RFC 9497 (OPRF) uses an uppercase V1, whereas OPAQUE uses a lowercase v. Very specific, but an inconsistency nonetheless 😄

@facebook-github-bot
Copy link

Hi @cyyynthia!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@kevinlewi
Copy link
Contributor

Ah, thank you, this is awesome!!

And nice catch on my mistake of claiming it was updated to version 16 without actually having updated it in the previous release. Apologies on that.

@kevinlewi kevinlewi merged commit 94d9c56 into facebook:main Sep 24, 2024
57 checks passed
@cyyynthia cyyynthia deleted the cynthia/draft-16 branch September 24, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants