Add support for new iOS text content type cellular EID and cellular IMEI (#46378) #46507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MEI (facebook#46378) Summary: Support for new iOS text content type to autofill cellular EID or cellular IMEI: - https://developer.apple.com/documentation/uikit/uitextcontenttypecellulareid?language=objc - https://developer.apple.com/documentation/uikit/uitextcontenttypecellularimei?language=objc ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [ADDED] - new text content type cellular EID and cellular IMEI Pull Request resolved: facebook#46378 Test Plan: JavaScript Tests - yarn test [PASSED] - No errors related with the changes Flow - yarn flow && yarn lint [PASSED] - No errors related with the changes iOS Tests - ./scripts/objc-test.sh test [PASSED] - No errors related with the changes Build RNTester [PASSED] - No errors related with the changes - Proof: <img width="838" alt="Screenshot 2024-09-07 at 12 06 48" src="https://github.com/user-attachments/assets/836a71f2-8adb-428f-b98d-8b84f71e93d6"> <img width="806" alt="Screenshot 2024-09-07 at 12 07 29" src="https://github.com/user-attachments/assets/7b33b919-3b29-4846-b6a2-3427dbbc2869"> <img width="1221" alt="Screenshot 2024-09-07 at 12 13 02" src="https://github.com/user-attachments/assets/58b369e9-5281-4a6b-9663-1cbd77439510">  Note: Since the test was done using an iOS simulator the autofill suggestion won't appear for the cellularEID or cellularIMEI Differential Revision: D62386126
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62737200 |
Summary: Support for new iOS text content type to autofill cellular EID or cellular IMEI: - https://developer.apple.com/documentation/uikit/uitextcontenttypecellulareid?language=objc - https://developer.apple.com/documentation/uikit/uitextcontenttypecellularimei?language=objc ## Changelog: [General][Added] - Add JS layer for new text content type cellular EID and cellular IMEI Reviewed By: cortinico Differential Revision: D62737200
|
This pull request was exported from Phabricator. Differential Revision: D62737200 |
cipolleschi
force-pushed
the
export-D62737200
branch
from
a614207
to
94038e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support for new iOS text content type to autofill cellular EID or cellular IMEI:
Changelog:
[General][Added] - Add JS layer for new text content type cellular EID and cellular IMEI
Test Plan:
JavaScript Tests - yarn test [PASSED]
Flow - yarn flow && yarn lint [PASSED]
iOS Tests - ./scripts/objc-test.sh test [PASSED]
Build RNTester [PASSED]
Note: Since the test was done using an iOS simulator the autofill suggestion won't appear for the cellularEID or cellularIMEI
Reviewed By: cortinico
Differential Revision: D62737200
Pulled By: cipolleschi