feat(iOS): add colors to codegen output #46557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Linter fails on API call for some reason |
okwasniewski
changed the title
|
The linter is saying that there are a bunch of things to change in one of the files you modified (specifically: |
okwasniewski
force-pushed
the
feat/codegen-colors
branch
from
08ce16e
to
4e6cf0e
Compare
okwasniewski
force-pushed
the
feat/codegen-colors
branch
from
4e6cf0e
to
95da57a
Compare
|
Thanks, @cipolleschi linter is green now! |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 1747f57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is a quality-of-life improvement, adds colors to codegen output:
Makes it a lot easier to grasp what's going on in the actions taken by codegen.
Changelog:
[GENERAL] [ADDED] - Add color formatting to codegen output
Test Plan: