Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RNTester dark mode Android Text examples #48380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix RNTester dark mode Android Text examples #48380

wants to merge 1 commit into from
+508 −401

Conversation

mateoguzmana
Copy link
Contributor

Summary:

The Android Text examples in dark mode are not readable. This PR addresses that by replacing the Text usages with RNTesterText.

Changelog:

[INTERNAL] [FIXED] - Fixing dark mode Android Text examples

Test Plan:

Some screenshots after the fixes.

Image 1 Image 2 Image 3 Image 4 Image 5
Screenshot_1734981250 Screenshot_1734981168 Screenshot_1734981146 Screenshot_1734981127 Screenshot_1734981115
Image 6 Image 7 Image 8 Image 9 Image 10
--------- --------- --------- --------- ---------
Screenshot_1734981101 Screenshot_1734981080 Screenshot_1734980904 Screenshot_1734981057 Screenshot_1734980876

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2024
@mateoguzmana mateoguzmana changed the title Fixing RNTester dark mode Android Text examples Fix RNTester dark mode Android Text examples Dec 24, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateoguzmana @facebook-github-bot