Packager: deep react-native field (also known as browser/resolve.alias) shim #9899
Conversation
…l require redirects
|
By analyzing the blame information on this pull request, we identified @davidaurelio to be a potential reviewer. |
ghost
added
GH Review: review-needed
CLA Signed
jacobrosenthal
changed the title
ghost
added
the
CLA Signed
|
👍 Pinging @davidaurelio once more |
ghost
added
the
CLA Signed
|
@davidaurelio Any chance you take a look at this so we can try and get it merged in? |
facebook-github-bot
added
the
CLA Signed
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @davidaurelio as a potential reviewer. Could you take a look please or cc someone with more context? |
facebook-github-bot
added
the
CLA Signed
| } | ||
| return modulePath; | ||
| }); | ||
| } |
There was a problem hiding this comment.
if (name === modulePath) {
return Promise.resolve(fromModule.getPackage()).then(resolveRoot);
}
return name;
| @@ -305,21 +307,38 @@ class ResolutionRequest { | |||
| }); | |||
| } | |||
|
|
|||
| _redirectRequire(fromModule, modulePath) { | |||
| return Promise.resolve(fromModule.getPackage()).then(p => { | |||
| _redirectRequire(fromModule, modulePath, rootModule) { | |||
There was a problem hiding this comment.
rootModule could be optional?
|
Ping @jacobrosenthal, see feedback above. |
|
Hey, it seems like this pull request has been abandoned. I am going to close this but if you are still working on it please feel free to reopen! I might be pulling the trigger a bit hastily but, well, let me know. |
Ive been maintaining a react native bluetooth package that attempts to bring over the extensive node bluetooth ecosystem from node to ios and android
Its been a longstanding request from many of us, sometimes with accompanying PR's sometimes without, to be able to use the react-native (browser elsewhere) field to shim packages.
facebookarchive/node-haste#46
mjohnston/react-native-webpack-server#75
#6253
https://productpains.com/post/react-native/packager-support-resolvealias-ala-webpack/
https://productpains.com/post/react-native/support-resolvealias-ala-webpack
Since then we got first level shims in the form of 'react-native' field in package.json. This attempts to store the root module and use its redirectRequire as a priority replacement before the current module's redirectRequire.
I know Ill need tests, and maybe even more implementation as I dont understand the cache/haste stuff yet but I haven't gotten any discussion in the discourse yet so Im hoping to spark some here.
Thanks in advance for any consideration or feedback