Skip to content

Commit

Permalink
[compiler][be] Clean up nested function context in DCE
Browse files Browse the repository at this point in the history
Now that we rely on function context exclusively, let's clean up `HIRFunction.context` after DCE. This PR is in preparation of #31204, which would otherwise have unnecessary declarations (of context values that become entirely DCE'd)
  • Loading branch information
mofeiZ committed Oct 24, 2024
1 parent d9b8b79 commit 93ebd24
Show file tree
Hide file tree
Showing 7 changed files with 46 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ export function deadCodeElimination(fn: HIRFunction): void {
}
}
}

/**
* Constant propagation and DCE may have deleted or rewritten instructions
* that reference context variables.
*/
retainWhere(fn.context, contextVar =>
state.isIdOrNameUsed(contextVar.identifier),
);
}

class State {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function Component() {
t0 = () => {
"worklet";

setCount((count_0) => count_0 + 1);
setCount(_temp);
};
$[0] = t0;
} else {
Expand All @@ -45,6 +45,9 @@ function Component() {
}
return t1;
}
function _temp(count_0) {
return count_0 + 1;
}

```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,7 @@ function getNativeLogFunction(level) {
if (arguments.length === 1 && typeof arguments[0] === "string") {
str = arguments[0];
} else {
str = Array.prototype.map
.call(arguments, function (arg) {
return inspect(arg, { depth: 10 });
})
.join(", ");
str = Array.prototype.map.call(arguments, _temp).join(", ");
}

const firstArg = arguments[0];
Expand Down Expand Up @@ -92,6 +88,9 @@ function getNativeLogFunction(level) {
}
return t0;
}
function _temp(arg) {
return inspect(arg, { depth: 10 });
}

```
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function Component() {
t0 = function update() {
"worklet";

setCount((count_0) => count_0 + 1);
setCount(_temp);
};
$[0] = t0;
} else {
Expand All @@ -51,6 +51,9 @@ function Component() {
}
return t1;
}
function _temp(count_0) {
return count_0 + 1;
}

export const FIXTURE_ENTRYPOINT = {
fn: Component,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function Component() {
let t0;
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t0 = () => {
setState((s) => s + 1);
setState(_temp);
};
$[0] = t0;
} else {
Expand Down Expand Up @@ -61,6 +61,9 @@ function Component() {
}
return t2;
}
function _temp(s) {
return s + 1;
}

```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,43 +39,33 @@ function Component() {
```javascript
import { c as _c } from "react/compiler-runtime"; // @enableAssumeHooksFollowRulesOfReact @enableTransitivelyFreezeFunctionExpressions
function Component() {
const $ = _c(8);
const $ = _c(7);
const items = useItems();
let t0;
let t1;
let t2;
if ($[0] !== items) {
t2 = Symbol.for("react.early_return_sentinel");
bb0: {
let t3;
if ($[4] === Symbol.for("react.memo_cache_sentinel")) {
t3 = (t4) => {
const [item] = t4;
return item.name != null;
};
$[4] = t3;
} else {
t3 = $[4];
}
t0 = items.filter(t3);
t0 = items.filter(_temp);
const filteredItems = t0;
if (filteredItems.length === 0) {
let t4;
if ($[5] === Symbol.for("react.memo_cache_sentinel")) {
t4 = (
let t3;
if ($[4] === Symbol.for("react.memo_cache_sentinel")) {
t3 = (
<div>
<span />
</div>
);
$[5] = t4;
$[4] = t3;
} else {
t4 = $[5];
t3 = $[4];
}
t2 = t4;
t2 = t3;
break bb0;
}

t1 = filteredItems.map(_temp);
t1 = filteredItems.map(_temp2);
}
$[0] = items;
$[1] = t1;
Expand All @@ -90,19 +80,23 @@ function Component() {
return t2;
}
let t3;
if ($[6] !== t1) {
if ($[5] !== t1) {
t3 = <>{t1}</>;
$[6] = t1;
$[7] = t3;
$[5] = t1;
$[6] = t3;
} else {
t3 = $[7];
t3 = $[6];
}
return t3;
}
function _temp(t0) {
function _temp2(t0) {
const [item_0] = t0;
return <Stringify item={item_0} />;
}
function _temp(t0) {
const [item] = t0;
return item.name != null;
}

```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function Component() {
let t0;
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t0 = () => {
setState((s) => s + 1);
setState(_temp);
};
$[0] = t0;
} else {
Expand Down Expand Up @@ -67,6 +67,9 @@ function Component() {
}
return t2;
}
function _temp(s) {
return s + 1;
}

export const FIXTURE_ENTRYPOINT = {
fn: Component,
Expand Down

0 comments on commit 93ebd24

Please sign in to comment.