[RN] Migrate from ReactNativeInternalFeatureFlags to a module in the react-native package #30978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rubennorte
force-pushed
the
use-rn-feature-flags
branch
from
f5aede0
to
9b2f350
Compare
rubennorte
force-pushed
the
use-rn-feature-flags
branch
from
9b2f350
to
c3e163c
Compare
rubennorte
force-pushed
the
use-rn-feature-flags
branch
from
c3e163c
to
49454f7
Compare
rubennorte
force-pushed
the
use-rn-feature-flags
branch
from
49454f7
to
364d4db
Compare
…react-native package
rubennorte
force-pushed
the
use-rn-feature-flags
branch
from
364d4db
to
b15c4bc
Compare
|
Comparing: a99d8e8...6c87138 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Meta builds for the React Native renderer reference a
ReactNativeInternalFeatureFlagsmodule that's expected to be defined in Haste when building the renderer together with RN at Meta. We're migrating away from this module and we've moved these definitions to the RN repository, so both definitions are OSS and we have more flexibility to define those flags at Meta (concretely, so we can use feature flags defined inreact-native/src/private/featureflags/ReactNativeFeatureFlagswithout having circular dependencies).How did you test this change?
Existing unit tests in React.
Will manually sync these changes to react-native to test the approach e2e.