Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intensify operations on same key in crash test #12148

Closed
wants to merge 1 commit into from

Conversation

hx235
Copy link
Contributor

@hx235 hx235 commented Dec 14, 2023

Context/Summary:

Continued from #12127, we can randomly reduce the # max key to coerce more operations on the same key. My experimental run shows it surfaced more issue than just #12127.

I also randomly reduce the related parameters, write buffer size and target file base, to adapt to randomly lower number of # max key. This creates 4 situations of testing, 3 of which are new:

  1. high # max key with high write buffer size and target file base (existing)
  2. high # max key with low write buffer size and target file base (new, will go through some rehearsal testing to ensure we don't run out of space with many files)
  3. low # max key with high write buffer size and target file base (new, keys will stay in memory longer)
  4. low # max key with low write buffer size and target file base (new, experimental runs show it surfaced even more issues)

Test plan:

  • [Ongoing] Rehearsal stress test
  • Monitor production stress test

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 added the WIP Work in progress label Dec 14, 2023
Copy link
Contributor

@jaykorean jaykorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hx235 hx235 force-pushed the small_db_stress_test branch from 923dce2 to 6c17eab Compare December 16, 2023 19:47
@facebook-github-bot
Copy link
Contributor

@hx235 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@hx235 merged this pull request in 5b981b6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants