Java API Auto close iterators #13132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpaxton
force-pushed
the
eb/iterator-crash-on-closed-db
branch
from
d8cdf34 to
0ae99e8
Compare
alanpaxton
force-pushed
the
eb/iterator-crash-on-closed-db
branch
from
1b6f9ff to
4603e58
Compare
ufochill
reviewed
Nov 21, 2024
In an analogous way to owning column family handles, and closing them when the DB itself is closed, we make iterators be “child” objects of the DB. Iterator lifecycle is generally shorter than DB, so we give them a lambda to remove themselves from the DB on iterator close(). Add a few tests to check that iterators which remain open when the DB is requested to close, are now closed when the DB is closed. TODO - other DB subclasses need to add iterators to the list TODO - there are cases where isOwningHandle() should not throw an exception; we need a less sledgehammer way of implementing this TODO - fix the current Java tests TODO - the atomic improvement in facebook#5234
alanpaxton
force-pushed
the
eb/iterator-crash-on-closed-db
branch
from
43b6e0c to
7aa0770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an analogous way to owning column family handles, and closing them when the DB itself is closed, we make iterators be “child” objects of the DB.
Iterator lifecycle is generally shorter than DB, so we give them a lambda to remove themselves from the DB on iterator close().
Add tests to check that iterators which remain open when the DB is requested to close, are now closed when the DB is closed.
This fixes #5234