Add -Wsuggest-destructor-override check

[archang19]

Summary

This was suggested in #13212 (comment). It should help reduce the discrepancy between our CI checks here and the CI checks that get run as part of releases to fbcode.

I am still not sure why the fbcode CI checked only complained about 2 instances of this missing override issue when there are clearly many, many more examples.

Note that with clang-10, this -Wsuggest-destructor-override option is not recognized, so I only add it for clang-13 in the MAKEFILE.

Test Plan

These updated GitHub CI checks should pass, and we should no longer run into the same surprise at release time in the fbcode repo.

[hx235]

I roughly remembered we have quite some places where destructor is not marked explicitly .... so maybe we need to mark them first to pass the new check?

[archang19]

I roughly remembered we have quite some places where destructor is not marked explicitly .... so maybe we need to mark them first to pass the new check?

Yes we do need to update a bunch of destructors. "Quite some places" is an understatement

[pdillinger]

Yeah sorry this turned out to be complicated, not just with gtest but with clang versions also. We primarily want to be sure our public API headers are clean of lots of warnings. We need to be prepared for however strictly our users choose to compile their own code.
This could be checked under the %.h.pub rule in the Makefile, but that doesn’t solve the clang version problem. We do have one warning compatibility check in build_detect_platform and could add this one, probably with a new Make/shell variable getting plumbed through.
See also #12319 re: recommended removing 'virtual' when redundant with 'override'.
Given the complications, it's also OK to drop this, or make a note to add it when the minimum clang version to support our supported C++ version includes support for the warning.