Add io_buffer_size to BackupEngineOptions #13236
Draft
+81
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The RocksDB backup engine code currently derives the IO buffer size based on the following criteria:
We want to be able to explicitly choose the IO size based on the storage backend. We want the new criteria to be:
BackupEngineOptions
This PR adds a new option called
io_buffer_size
toBackupEngineOptions
and updates the logic used to set the buffer size.Test Plan
I added a separate unit test and verified that we can either use the
io_buffer_size
, rate limiter burst size, or the default size.I decided to use a
TEST_SYNC_POINT_CALLBACK
. I considered the alternative of updating theRead
implementation ofDummySequentialFile
/CheckIOOptsSequentialFile
to check the value ofn
. However, that would have considerably complicated the whole test code, and we also do not need to be checking for this in every single test case. I think theTEST_SYNC_POINT_CALLBACK
turned out to be quite elegant.