Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support flush reasons above 12 in Java integration #13246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support flush reasons above 12 in Java integration #13246

wants to merge 1 commit into from
+4 −1

Conversation

rpuch
Copy link
Contributor

@rpuch rpuch commented Dec 25, 2024

Summary:

FlushReason enum in C++ has members up to 15, but in Java, the mirroring FlushReason only supports reason codes up to 12. This causes exceptions when adding a flush listener.

@rpuch
Support flush reasons above 12 in Java integration
5f100c7 
Summary:

FlushReason enum in C++ has members up to 15, but in Java, the mirroring FlushReason only supports reason codes up to 12. This causes exceptions when adding a flush listener.
@rpuch
Copy link
Contributor Author

rpuch commented Dec 25, 2024

Here is what can be seen on the console (probably, it's stderr) during flushes:

java.lang.IllegalArgumentException: Illegal value provided for FlushReason: 13
        at org.rocksdb.FlushReason.fromValue(FlushReason.java:51)
        at org.rocksdb.FlushJobInfo.<init>(FlushJobInfo.java:41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpuch @facebook-github-bot