Demonstration: fixes the pywatchman build script and documents how to publish an updated version to pypi #1074
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default src directory in the setup script was missing a relative parent traversal, making it impossible to build without setting the environment variable CMAKE_CURRENT_SOURCE_DIR. This change fixes the relative path allowing the build to proceed.
An unofficial build will be published to pypi given there hasn't been an official release since 2017. pywatchman is a dependency for Django projects and is no longer able to run with recent versions of watchman. This is a temporary unofficial release meant to unblock those depending on pywatchman that are unable to use it. Hopefully this spurs Facebook into publishing a new version.
The notes in `setup.py` for building and publishing the package are not complete, as cibuildwheel requires a little bit of it's own setup, but the instructions are a decent guide to getting it done if someone wants to replicate their build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pywatchman hasn't seen a release in 5 years: https://pypi.org/project/pywatchman/1.4.1/
The main watchman project is now incompatible with pywatchman meaning the pywatchman library is effectively dead without a new release.
I spent some time figuring out how to build it and have published an unofficial version from the latest (as of 2022-11-21) checkout. I've included some sparse notes within
setup.pyon how I built and published in case it's useful to anyone wanting to publish or maintain their own version, or to spur some interest from Meta folk that might want to publish an official update.I don't expect this PR to be merged, particularly since only the first commit (fixing the build dir path) is relevant to the official distribution.
#1065
https://pypi.org/project/pywatchman-unofficial/1.5.0/