-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update react, withProps coverage, context api migration #474
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the pull request with hope! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hey @kyldvs , are you able to review? |
Hey @tomtwttr, thanks for the PR! Sorry for the delay, I was holding off because it looked like a draft PR for a while :) This looks good to me. Before I merge I will just need to make sure these changes don't cause any problems in our internal repos. This is because we like to have code on facebook org reflect what we are actually using in production, so I wouldn't want it to diverge too much. I will update you once I've pulled this in and checked. |
Thanks @kyldvs , apologies for the draft mode, was waiting for that "CLA Signed" process to go through. I look forward to hearing your results. |
Looks good :) thanks! |
@kyldvs What's the process for an NPM version bump? |
Isn't the version with this pull request published on npm? |
@kyldvs Would you be able to bump npm? |
@kyldvs @mariobanks Is this library no longer pushed to npm? |
This diff:
Adds code coverage to
componentWillReceiveProps
of FluxContainer. This is necessary before proper fix forUNSAFE_componentWillReceiveProps
can be implemented. This relates to FluxContainer: Unsafe lifecycle methods were found within a strict-mode tree #452 .Updates to migrate to new
Context
API