Add USE_TANH_FOR_SIGMOID flag for CUDA codegen. #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48097853 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: facebookincubator#881 We surface USE_TANH_FOR_SIGMOID to AIT level, that applies not only for CUTLASS but AIT computation too. Differential Revision: D48097853 fbshipit-source-id: 2835e0ddc781632a8fa78a46919ade8bcfe60559
muchulee8
force-pushed
the
export-D48097853
branch
from
a9d10f0
to
b939e58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48097853 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: facebookincubator#881 We surface USE_TANH_FOR_SIGMOID to AIT level, that applies not only for CUTLASS but AIT computation too. Differential Revision: D48097853 fbshipit-source-id: a5105b80895bb0c21879afb38b6c8546a94b3c20
muchulee8
force-pushed
the
export-D48097853
branch
from
b939e58
to
03f2bd4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48097853 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Aug 8, 2023
Summary: Pull Request resolved: facebookincubator#881 We surface USE_TANH_FOR_SIGMOID to AIT level, that applies not only for CUTLASS but AIT computation too. Reviewed By: amateurcoffee, aakhundov Differential Revision: D48097853 fbshipit-source-id: e028dd3e4769a3f3972fea289ac4a5483e8e14a6
muchulee8
force-pushed
the
export-D48097853
branch
from
03f2bd4
to
33bf51c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48097853 |
Summary: Pull Request resolved: facebookincubator#881 We surface USE_TANH_FOR_SIGMOID to AIT level, that applies not only for CUTLASS but AIT computation too. Reviewed By: amateurcoffee, aakhundov Differential Revision: D48097853 fbshipit-source-id: 0cc57db23e952682f1bbeb91a2ab5c76d000eb13
muchulee8
force-pushed
the
export-D48097853
branch
from
33bf51c
to
9d1d98b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48097853 |
|
This pull request has been merged in 38aebd9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We surface USE_TANH_FOR_SIGMOID to AIT level, that applies not only for CUTLASS but AIT computation too.
Differential Revision: D48097853