Fix edit_step backup working directory handling #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix `edit_step` to make `backup_file` also use `FetchAbs` just like the target file. Update example in `ForgeArmory` to reflect new behavior I think this was actually ok once we switched back to doing a top-level directory change in RunSteps, but either way it is better to have this redundancy. Differential Revision: D51307671
d3sch41n
requested review from
l50,
cedowens,
godlovepenn and
twinvega
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D51307671 |
d3sch41n
added a commit
to d3sch41n/TTPForge
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebookincubator/ForgeArmory#97 Fix `edit_step` to make `backup_file` also use `FetchAbs` just like the target file. Update example in `ForgeArmory` to reflect new behavior I think this was actually ok once we switched back to doing a top-level directory change in RunSteps, but either way it is better to have this redundancy. Differential Revision: D51307671
facebook-github-bot
pushed a commit
to facebookincubator/TTPForge
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: #418 X-link: facebookincubator/ForgeArmory#97 Fix `edit_step` to make `backup_file` also use `FetchAbs` just like the target file. Update example in `ForgeArmory` to reflect new behavior I think this was actually ok once we switched back to doing a top-level directory change in RunSteps, but either way it is better to have this redundancy. Reviewed By: cedowens Differential Revision: D51307671 fbshipit-source-id: 2873deaa792922e63899ec79d7cb1af19c9d2ede
|
This pull request has been merged in 03882db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix
edit_stepto makebackup_filealso useFetchAbsjust like the target file.Update example in
ForgeArmoryto reflect new behaviorI think this was actually ok once we switched back to doing a top-level directory change in RunSteps, but either way it is better to have this redundancy.
Differential Revision: D51307671