Magefile updates #402
Closed
Magefile updates #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D50618372 |
l50
changed the title
magefiles upkeep and documentation.
…entation. (facebookincubator#402) Summary: **Added:** - `magefiles/README.md` - New README for the `magefiles` directory detailing functions, usage examples, and contributing guidelines. - `magefiles/tmpl/README.md.tmpl` - Enhanced template for more descriptive README files for the `magefiles` package. - `docgen.go` - Extracted documentation generation logic from `magefile.go`. - `testing.go` - Segregated testing-related functions from `magefile.go`. **Changed:** - `.tool-versions` - Updated Go to version 1.21.3 and Python to version 3.12.0. - `magefiles/tmpl/README.md.tmpl` - Adjusted for better `magefiles` package documentation structure. - `magefile.go` - Split code into multiple files for easier maintenance and better organization. - Patched older net library for enhanced security and performance. Reviewed By: d3sch41n Differential Revision: D50618372
|
This pull request was exported from Phabricator. Differential Revision: D50618372 |
|
This pull request has been merged in ad00b0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactored
magefiles/magefile.goand updated documentation and tool versions for magefiles.Added:
magefiles/README.md- New README for themagefilesdirectory detailingfunctions, usage examples, and contributing guidelines.
magefiles/tmpl/README.md.tmpl- Enhanced template for more descriptiveREADME files for the
magefilespackage.docgen.go- Extracted documentation generation logic frommagefile.go.testing.go- Segregated testing-related functions frommagefile.go.Changed:
.tool-versions- Updated Go to version 1.21.3 and Python to version 3.12.0.magefiles/tmpl/README.md.tmpl- Adjusted for bettermagefilespackagedocumentation structure.
magefile.go- Split code into multiple files for easier maintenance andbetter organization.
Differential Revision: D50618372