Use smart buffering #520
Closed
Use smart buffering #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inesusvet
requested review from
d3sch41n,
cedowens,
d0n601,
CrimsonK1ng and
RoboticPrism
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D66702400 |
inesusvet
added a commit
to inesusvet/TTPForge
that referenced
this pull request
Dec 4, 2024
Summary: when reading the subprocess stdout to prevent extra new lines in output Inspired by https://github.com/uber-go/zap/blob/0ba452dbe15478739ad4bab1067706018a3062c6/zapio/writer.go#L100 --- ttpforge reads stdout/stderr inaccurately causing such lines in logs: ``` INFO [STDERR] curl: (56) Received HTT INFO [STDERR] P code 407 from proxy after CONNECT ``` the code: https://fburl.com/code/52hzjy4j Differential Revision: D66702400
inesusvet
force-pushed
the
export-D66702400
branch
from
64e456f to
d49962c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66702400 |
Summary: when reading the subprocess stdout to prevent extra new lines in output Inspired by https://github.com/uber-go/zap/blob/0ba452dbe15478739ad4bab1067706018a3062c6/zapio/writer.go#L100 --- ttpforge reads stdout/stderr inaccurately causing such lines in logs: ``` INFO [STDERR] curl: (56) Received HTT INFO [STDERR] P code 407 from proxy after CONNECT ``` the code: https://fburl.com/code/52hzjy4j Differential Revision: D66702400
inesusvet
force-pushed
the
export-D66702400
branch
from
d49962c to
5073da5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66702400 |
|
This pull request has been merged in 1d2f42f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
when reading the subprocess stdout to prevent extra new lines in output
Inspired by https://github.com/uber-go/zap/blob/0ba452dbe15478739ad4bab1067706018a3062c6/zapio/writer.go#L100
ttpforge reads stdout/stderr inaccurately causing such lines in logs:
the code: https://fburl.com/code/52hzjy4j
Differential Revision: D66702400