Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

refine densepose coco evaluation code #203

Closed

Conversation

Johnqczhang
Copy link

  1. Refine python code style by adding blanks;
  2. Simplify some codes used to compute geodesic point similarity measure (Why write the code so complicated when getting pairwise geodesic distances #202) and evaluation on each image;
  3. Rename some variables based on their function/purpose;
  4. Add more comments to improve readability.

After refinement, the evaluation results of densepose body UV is the same as previous.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 19, 2019
@Johnqczhang Johnqczhang reopened this Feb 24, 2019
@Johnqczhang
Copy link
Author

I'm very sorry for my carelessness in my previous submits which caused very unprofessional operations for a PR. For the convenience, I rollbacked two times to fix all bugs in one submit. The revised version has been fully tested on the "dense_coco_2014_minival" dataset and the same results have been obtained as the provided in MODEL ZOO.

@Johnqczhang
Copy link
Author

Closing this PR since it has already been covered in a more comprehensive refinements #215

@Johnqczhang Johnqczhang deleted the refine_dp_coco_eval branch March 15, 2019 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants