This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
Add vanilla and optimized cpu device to detectron #596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use this PR to initiate the support of CPU device paths in detectron. Changes are made minimal in this PR to ask the advice from the community a good integration approach to follow. There are two major changes:
Renaming the hard-coded GpuNameScope/CudaScope to more general names might be a more elegant approach but this would require changes of many places in detectron code. Any suggestions?