Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Feature/replaceable detection helper #690

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DXist
Copy link

@DXist DXist commented Oct 1, 2018

These changes aim to make detectron more extensible as an external dependency.

  1. model type func can be imported from environment by absolute python path. This allows to define helpers for custom architecture outside of the project directory. Particularly I'm interested to use ResNet18.
  2. DetectionModelHelperclass can be replaced by custom implementation. In my case I want to override TrainableParams method to train only parameters related to mask.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

DXist added 2 commits October 10, 2018 10:38
tools/infer_simple.py works with python3.7 and caffe2 installed with pytorch
@DXist
Copy link
Author

DXist commented Oct 10, 2018

Fixed infer_simple test.

Test is run in custom docker image with fresh pytorch-nightly and python 3.7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants