aepsych buddy plotting upstream #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67771447 |
JasonKChow
force-pushed
the
export-D67771447
branch
from
3f67b39 to
b7e8565
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67771447 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 4, 2025
Summary: Plotting refactor from aepsych buddy upstreamed. The old mega plotting functions are being deprecated in favour for smaller utility plotting functions with an API closer to Seaborn intended to work with the object oriented plot API of Matplotlib. Major plotting components are split up and are intended to directly apply to a Matplotlib Axes. The new functions no longer accept strategies and the user is expected to be able to calculate the values as necessary using the model API. We deprecate the old strategy functions in favour for separate plotting functions that are easier to compose into bespoke plots, largely following the matplotlib API more closely. Differential Revision: D67771447
JasonKChow
force-pushed
the
export-D67771447
branch
from
b7e8565 to
e613817
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67771447 |
JasonKChow
force-pushed
the
export-D67771447
branch
from
e613817 to
d6f0a24
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 11, 2025
Summary: Plotting refactor from aepsych buddy upstreamed. The old mega plotting functions are being deprecated in favour for smaller utility plotting functions with an API closer to Seaborn intended to work with the object oriented plot API of Matplotlib. Major plotting components are split up and are intended to directly apply to a Matplotlib Axes. The new functions no longer accept strategies and the user is expected to be able to calculate the values as necessary using the model API. We deprecate the old strategy functions in favour for separate plotting functions that are easier to compose into bespoke plots, largely following the matplotlib API more closely. Differential Revision: D67771447
|
This pull request was exported from Phabricator. Differential Revision: D67771447 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 11, 2025
Summary: Plotting refactor from aepsych buddy upstreamed. The old mega plotting functions are being deprecated in favour for smaller utility plotting functions with an API closer to Seaborn intended to work with the object oriented plot API of Matplotlib. Major plotting components are split up and are intended to directly apply to a Matplotlib Axes. The new functions no longer accept strategies and the user is expected to be able to calculate the values as necessary using the model API. We deprecate the old strategy functions in favour for separate plotting functions that are easier to compose into bespoke plots, largely following the matplotlib API more closely. Differential Revision: D67771447
JasonKChow
force-pushed
the
export-D67771447
branch
from
d6f0a24 to
42ff399
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67771447 |
…bookresearch#514) Summary: Models (and maybe some generators) can change modes (`model.train()` and `model.eval()`). When parameter wrapped, these are still possible but the transforms do not follow the mode. For base objects that cannot change modes, we just modify the transform. Reviewed By: crasanders Differential Revision: D68033333
Summary: Plotting refactor from aepsych buddy upstreamed. The old mega plotting functions are being deprecated in favour for smaller utility plotting functions with an API closer to Seaborn intended to work with the object oriented plot API of Matplotlib. Major plotting components are split up and are intended to directly apply to a Matplotlib Axes. The new functions no longer accept strategies and the user is expected to be able to calculate the values as necessary using the model API. We deprecate the old strategy functions in favour for separate plotting functions that are easier to compose into bespoke plots, largely following the matplotlib API more closely. Differential Revision: D67771447
JasonKChow
force-pushed
the
export-D67771447
branch
from
42ff399 to
9e87046
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67771447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Plotting refactor from aepsych buddy upstreamed.
We deprecate the old strategy functions in favour for separate plotting functions that are easier to compose into bespoke plots, largely following the matplotlib API more closely.
Differential Revision: D67771447