Implement Fixed Parameter Asks #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 9, 2025
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Differential Revision: D67956510
JasonKChow
force-pushed
the
export-D67956510
branch
from
c42b255 to
66d4a05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Differential Revision: D67956510
JasonKChow
force-pushed
the
export-D67956510
branch
from
66d4a05 to
cfcb187
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
JasonKChow
force-pushed
the
export-D67956510
branch
from
cfcb187 to
4ee84a0
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Differential Revision: D67956510
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Differential Revision: D67956510
JasonKChow
force-pushed
the
export-D67956510
branch
from
4ee84a0 to
2f84c9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Differential Revision: D67956510
JasonKChow
force-pushed
the
export-D67956510
branch
from
2f84c9f to
5baf9d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Differential Revision: D67956510
JasonKChow
force-pushed
the
export-D67956510
branch
from
5baf9d5 to
9fda8ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Reviewed By: crasanders Differential Revision: D67997208
Summary: Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated. This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive. To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it. Reviewed By: crasanders Differential Revision: D67956510
JasonKChow
force-pushed
the
export-D67956510
branch
from
9fda8ff to
3c85fb9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67956510 |
|
This pull request has been merged in 85c97e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow asks to provide some some parameter values to fix when generating points. When set only the unset parameters will be automatically generated.
This more or less only works for OptimizeAcqfGenerator. Other generators will simply throw a warning and ignore the directive.
To conform API, every generator's gen method now includes the **kwargs but most of them will simply ignore it.
Differential Revision: D67956510