This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Add unit distribution for adding to log prob #1051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Addresses [#1041](facebookresearch/beanmachine#1041). Imported the Unit Dist (with some minor modifications) from pyro. This will allow users to add terms to the model density: ``` bm.random_variable def increment_log_prob(): val = Normal(0., 1.).log_prob(1.) return Unit(val) ``` In the future we can wrap this with a `factor` statement. Reviewed By: neerajprad Differential Revision: D31516303 fbshipit-source-id: 171e08797cd0367dd985f13b149c9c766c6fddef
|
This pull request was exported from Phabricator. Differential Revision: D31516303 |
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses #1041. Imported the Unit Dist (with some minor modifications) from pyro. This will allow users to add terms to the model density:
In the future we can wrap this with a
factorstatement.Reviewed By: neerajprad
Differential Revision: D31516303