Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Marginal diagnostic tool #1691

Closed
wants to merge 7 commits into from
Closed

Marginal diagnostic tool #1691

wants to merge 7 commits into from

Commits on Sep 21, 2022

  1. Marginal diagnostic tool

    This commit includes the marginal 1D diagnostic tool with JavaScript
    callbacks.
    ndmlny-qs committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2807d16 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Documentation & remove arviz

    - Removes ArviZ as a dependency from the diagnostic tool.
    - Adds jsdoc Documentation for the TypeScript methods.
    - Fixes flake8 linting error.
    - Adds clarifying comments to the tool.
    - Adds missing copyright notice.
    ndmlny-qs committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b2c474e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    08cb37e View commit details
    Browse the repository at this point in the history
  2. Refactor

    - Aligns type names between Python and TypeScript. There is now a
      one-to-one correspondence between Python TypedDict objects and the
      TypeScript interface objects.
    - Redundancy in the Python TypedDict objects has been removed.
    - Fixes tooltips not rendering correctly.
    - Updates the link in the Help Tab of the tool such that when clicked it
      opens a new tab in the browser.
    - Moves a few peerDependencies to the devDependencies section in the
      package.json file. This was done because yarn issued a warning
      indicating there were missing peer dependencies.
    - Refactors the tool such that no calculations for the data displayed is
      done in Python. All updates and all calculations for the tool data is
      done exclusively in the browser. The rational for this change was to
      prevent users from having initial data calculated by Python, and
      subsequent updates calculated by JavaScript in the browser when
      interacting with the tool. There are notes in the code indicating why
      this change was made.
    ndmlny-qs committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    c6d0720 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Better UX for required user interaction

    - Moved all Bokeh embed from the tool class to the base class.
    - Updated tool class docs.
    - New method on the base class that contains an HTML template for more
      intuitive required UI for better UX.
    - Reordered how the tool view is created in order to attach the new CSS
      class for the UI/UX updates.
    ndmlny-qs committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    911e0d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Refactor

    - Refactors dosctrings from NumPy to Google style.
    - Added a prettierrc for dev and updated the package.json, yarn.lock
      files
    - Refactored the marginal1d tool for responsive size changes and updated
      to the format that allows Docusaurus integration.
    - Added more documentation around the accessor objects with an explicit
      example in the docstring.
    ndmlny-qs committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3010f00 View commit details
    Browse the repository at this point in the history
  2. fix linting error

    ndmlny-qs committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f4942fa View commit details
    Browse the repository at this point in the history