Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Trace tool #1723

Closed
wants to merge 7 commits into from
Closed

Trace tool #1723

wants to merge 7 commits into from

Commits on Oct 24, 2022

  1. Marginal diagnostic tool 

    This commit includes the marginal 1D diagnostic tool with JavaScript
callbacks.
    @ndmlny-qs
    ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    f85ff15 View commit details
    Browse the repository at this point in the history

  2. Documentation & remove arviz 

    - Removes ArviZ as a dependency from the diagnostic tool.
- Adds jsdoc Documentation for the TypeScript methods.
- Fixes flake8 linting error.
- Adds clarifying comments to the tool.
- Adds missing copyright notice.
    @ndmlny-qs
    ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    37c0067 View commit details
    Browse the repository at this point in the history

  3. Refactor 

    - Aligns type names between Python and TypeScript. There is now a
  one-to-one correspondence between Python TypedDict objects and the
  TypeScript interface objects.
- Redundancy in the Python TypedDict objects has been removed.
- Fixes tooltips not rendering correctly.
- Updates the link in the Help Tab of the tool such that when clicked it
  opens a new tab in the browser.
- Moves a few peerDependencies to the devDependencies section in the
  package.json file. This was done because yarn issued a warning
  indicating there were missing peer dependencies.
- Refactors the tool such that no calculations for the data displayed is
  done in Python. All updates and all calculations for the tool data is
  done exclusively in the browser. The rational for this change was to
  prevent users from having initial data calculated by Python, and
  subsequent updates calculated by JavaScript in the browser when
  interacting with the tool. There are notes in the code indicating why
  this change was made.
    @ndmlny-qs
    ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    27b8c69 View commit details
    Browse the repository at this point in the history

  4. Trace diagnostic tool 

    This tool branches from the marginal1d tool and rebases against main.
Added files include those needed for displaying a Trace diagnostic tool
for Bean Machine models.

This also updates the Coin_flipping.ipynb tutorial to include the new
diagnostic tool.
    @ndmlny-qs
    ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    1d32e05 View commit details
    Browse the repository at this point in the history

  5. Update trace tool to use DiagnosticToolBaseClass

    @horizon-blue @ndmlny-qs
    horizon-blue authored and ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    dcc83ae View commit details
    Browse the repository at this point in the history

  6. Revert the hacky change for N-d tensors

    @horizon-blue @ndmlny-qs
    horizon-blue authored and ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    2168998 View commit details
    Browse the repository at this point in the history

  7. Rebase etc 

    - Rebased against `main`, and fixed merged conflicts.
- Updated copyright requirement
- Updated how models are serialized.
- Update style based on other pushes to the branch
- Added `__future__` annotations
- updated a few docstrings that needed an update
- updated yarn lock based on changes with the marginal1d tool and the
  trace tool.
- removed the 3rd party histogram requirement, since it is easy to
  calculate a histogram.
- other fixes associated with merging etc.
    @ndmlny-qs
    ndmlny-qs committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5c6019f View commit details
    Browse the repository at this point in the history