resolve last nit comment

facebookresearch · Oct 5, 2023 · e2dcab6 · e2dcab6
1 parent a6e5a58
commit e2dcab6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/fairseq2n/src/fairseq2n/data/composite_data_source.cc b/fairseq2n/src/fairseq2n/data/composite_data_source.cc
@@ -13,8 +13,8 @@ composite_data_source::composite_data_source(
     index_generator_fn &&index_gen_fn,
     bool stop_at_shortest)
   : pipelines_(std::move(pipelines)),
-    next_index_gen_(std::move(index_gen_fn)),
-    stop_at_shortest_(stop_at_shortest)
+    next_index_gen_{std::move(index_gen_fn)},
+    stop_at_shortest_{stop_at_shortest}
 {
     if (!stop_at_shortest) {
         is_epoch_done_ = std::vector<bool>(pipelines_.size(), false);

diff --git a/src/fairseq2/data/data_pipeline.py b/src/fairseq2/data/data_pipeline.py
@@ -103,9 +103,9 @@ def round_robin(
             :param pipelines:
                 The data pipelines to round robin.
             :param stop_at_shortest:
-                Flag to stop round_robin when first pipeline reaches its end.
-                If set to False, we circle around finished pipelines until all
-                data pipelines reach their end.
+                If ``True``, stop round_robin when first pipeline reaches its end.
+                If ``False``, circle around finished pipelines until all pipelines
+                reach their end.
             """
 
         @staticmethod
@@ -121,9 +121,9 @@ def sample(
             :param weights:
                 Desired distribution of pipelines. If None, use uniform distribution.
             :param stop_at_shortest:
-                Flag to stop sampling when first pipeline reaches its end.
-                If set to False, we circle around finished pipelines until all
-                data pipelines reach their end.
+                If ``True``, stop sampling when first pipeline reaches its end.
+                If ``False``, circle around finished pipelines until all pipelines
+                reach their end.
             """
 
         @staticmethod