-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concatenate method for DataPipeline class #84
Conversation
Hi @am831! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first PR! My main feedback/question is why we need to have two lists of pipelines. I think the ideal API should look like .concat(pipelines: Sequence[DataPipeline])
(in C++ .concat(std::vector<data_pipeline> pipelines)
, so I can't see the reason for the second "pipelines2".
Looks like there are also some linting and build issues that you can check at the bottom of the PR conversation pane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Looks good to me. Please make sure to annotate your python test class TestConcatOp
as I mentioned in our chat. There is also a subtle bug in the constructor initializer, but otherwise looks good to me. Let me know once you addressed the two points and I can stamp it right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do? Please describe:
Implements
concat
method in theDataPipeline
class which concatenates two data pipelines.Check list: