Skip to content

Commit

Permalink
Use different action for creating releases (#97)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #97

Notice that the releases are getting overridden - https://github.com/facebookresearch/fbpcf/releases

even though the tags are being properly set - https://github.com/facebookresearch/fbpcf/tags

Seems like this library is buggy. I am now using the library that folly uses - https://github.com/facebook/folly/blob/main/.github/workflows/TagIt.yml

Even though this action is not actively developed, v1 is stable and is good enough for folly...and folly is pretty trustworthy

Reviewed By: wuman

Differential Revision: D34931681

fbshipit-source-id: 2a44848d88f154985fa7b4516d1b5ba71e2f0c9f
  • Loading branch information
adshastri authored and facebook-github-bot committed Mar 16, 2022
1 parent 2d4496b commit 60f015c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ jobs:
docker push --all-tags ${{ env.REGISTRY_IMAGE_NAME }}
- name: Create release
uses: "marvinpinto/action-automatic-releases@latest"
uses: "actions/create-release@v1"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
prerelease: false
repo_token: "${{ secrets.GITHUB_TOKEN }}"
automatic_release_tag: "latest"
title: ${{ steps.create_version.outputs.version_tag }}
release_name: ${{ steps.create_version.outputs.version_tag }}
tag_name: ${{ steps.create_version.outputs.version_tag }}

- name: Cleanup
run: |
Expand Down

0 comments on commit 60f015c

Please sign in to comment.