Remove track_root_inv_residuals #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67468834 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 19, 2024
Summary: Deprecate `track_root_inv_residual` flag. Differential Revision: D67468834
tsunghsienlee
force-pushed
the
export-D67468834
branch
from
92ccb65 to
9293a16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67468834 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 19, 2024
Summary: Deprecate `track_root_inv_residual` flag. Differential Revision: D67468834
tsunghsienlee
force-pushed
the
export-D67468834
branch
from
9293a16 to
a7b27f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67468834 |
Summary: Deprecate `track_root_inv_residual` flag. Differential Revision: D67468834
tsunghsienlee
force-pushed
the
export-D67468834
branch
from
a7b27f2 to
df0412c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67468834 |
runame
approved these changes
Dec 19, 2024
Yes, although Shampoo is not using that; I think it has no harm to keep that. |
|
This pull request has been merged in f8ef043. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Deprecate
track_root_inv_residualflag.Differential Revision: D67468834