Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typographical errors #213

Closed
wants to merge 1 commit into from
Closed

fix typographical errors #213

wants to merge 1 commit into from

Conversation

ShuoShenDe
Copy link

This PR addresses two main issues identified in the code:

  1. Documentation Update in mask_to_box: Corrected the input description from [B, 1, H, W] boxes to [B, 1, H, W] masks to accurately reflect that the input is masks, not boxes.
  2. Variable Name Consistency in AsyncVideoFrameLoader: Updated comments to consistently use self.images instead of the previously incorrect self._images. This change ensures clarity and correctness in the asynchronous loading process documentation.

@ronghanghu
Copy link
Contributor

Thanks! We addressed this in #218

@ronghanghu ronghanghu closed this Aug 14, 2024
@ShuoShenDe ShuoShenDe deleted the fix_doc branch August 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed typo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShuoShenDe @ronghanghu @facebook-github-bot